[ 
https://issues.apache.org/jira/browse/YARN-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534737#comment-15534737
 ] 

Subru Krishnan commented on YARN-5384:
--------------------------------------

Thanks [~seanpo03] for addressing my comments. 

The latest patch is very close, have a few minor suggestions:
  * In YARN {{Priority}} is a inverse value, i.e. lower the value higher the 
absolute Priority. Can you kindly update the docs accordingly.
  * This statement is not fully correct:
bq. Note that a recurring reservation will implicitly have the highest possible 
priority
Recurring reservations are always higher priority than non-recurring ones and 
we compare Priority within each group as described above.
  * We should use *Priority.UNDEFINED* if Priority is not specified.
  * All the API changes related to Priority should be marked _unstable_. Can 
you also update the ones related to recurrence and name as they are currently 
incorrectly annotated.


> Expose priority in ReservationSystem submission APIs
> ----------------------------------------------------
>
>                 Key: YARN-5384
>                 URL: https://issues.apache.org/jira/browse/YARN-5384
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler, fairscheduler, resourcemanager
>            Reporter: Sean Po
>            Assignee: Sean Po
>         Attachments: YARN-5384.v1.patch, YARN-5384.v2.patch, 
> YARN-5384.v3.patch, YARN-5384.v4.patch, YARN-5384.v5.patch, 
> YARN-5384.v6.patch, YARN-5384.v7.patch, YARN-5384.v8.patch
>
>
> YARN-5211 proposes adding support for generalized priorities for reservations 
> in the YARN ReservationSystem. This JIRA is a sub-task to track the changes 
> needed in ApplicationClientProtocol to accomplish it. Please refer to the 
> design doc in the parent JIRA for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to