[ 
https://issues.apache.org/jira/browse/YARN-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15543874#comment-15543874
 ] 

Wangda Tan commented on YARN-2009:
----------------------------------

[~sunilg],

bq. orderedApps is a list of TempAppPerPartition and comparator is designed 
based on FiFo. So initial list is created from the PriorityQueue, and we 
removed each entry from top to get the high priority app. orderedApps has just 
collected those apps in order, and then later re-sorted to get apps in reverse 
order. tq.getApps return FiCaSchedulerApp, but we need TempAppPerPartition. So 
i think orderedApps is needed for the logic. Did i miss something?

This is only a minor comment: what I meant is, if {{orderedApps}} need to be 
re-sort (Use Collection.sort(list, comparator), you don't need to do the 
remove-and-add logic. Instead you can do not remove and re-sort the first list. 
Let me know if I didn't understand it correctly..

> Priority support for preemption in ProportionalCapacityPreemptionPolicy
> -----------------------------------------------------------------------
>
>                 Key: YARN-2009
>                 URL: https://issues.apache.org/jira/browse/YARN-2009
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Devaraj K
>            Assignee: Sunil G
>         Attachments: YARN-2009.0001.patch, YARN-2009.0002.patch, 
> YARN-2009.0003.patch, YARN-2009.0004.patch
>
>
> While preempting containers based on the queue ideal assignment, we may need 
> to consider preempting the low priority application containers first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to