[
https://issues.apache.org/jira/browse/YARN-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552332#comment-15552332
]
Varun Saxena commented on YARN-5699:
------------------------------------
Thanks [~rohithsharma] for the latest patch.
Few comments:
# In NMTimelinePublisher#publishContainerEvent, shouldn't we check against
httpAddress being null ? Instead of not being null.
# I see that we are publishing tracking URL twice. If AHS is enabled, tracking
URL is changed to AHS web endpoint when attempt finishes. So info field will
have its latest value as AHS url. In that case it should be attached to event
also so that we know the original AM tracking URL too (i.e. when attempt was
registered). Thoughts ?
# In TimelineServiceV2Publisher#appStateUpdated, changes are not required as we
are effectively doing the same thing as before. We should definitely publish
this info at event level because event is app state update event. Also should
we update it at info level too so that we can filter apps while they are
running based on their current state ?
# Do we need to publish master container info at app attempt level twice ?
bq. Updated patch also fixes a another bug i.e always NM published http address
port used to come as zero.
Thanks for the fix.
> Retrospect yarn entity fields which are publishing in events info fields.
> -------------------------------------------------------------------------
>
> Key: YARN-5699
> URL: https://issues.apache.org/jira/browse/YARN-5699
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Attachments: 0001-YARN-5699.YARN-5355.patch, 0001-YARN-5699.patch,
> 0002-YARN-5699.YARN-5355.patch
>
>
> Currently, all the container information are published at 2 places. Some of
> them are at entity info(top-level) and some are at event info.
> For containers, some of the event info should be published at container info
> level. For example : container exist status, container state, createdTime,
> finished time. These are general information to container required for
> container-report. So it is better to publish at top level info field.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
