[ 
https://issues.apache.org/jira/browse/YARN-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570493#comment-15570493
 ] 

Subru Krishnan commented on YARN-5325:
--------------------------------------

Thanks [~curino] for the updated patch. +1 from my side pending fix for 
checkstyle warnings.

A couple of nits:
  * I think it'll help to have a simple private method to assert expected 
_numConatiners_ for a _subCluster_ in {{TestLocalityMulticastAMRMProxyPolicy}}.
  * Thanks for the code comments for tests, found it useful. Can you please add 
for *testSplitBasedOnHeadroomAndWeights* also.
  * If possible can you update to use slf4j for logging throughout.

> Stateless ARMRMProxy policies implementation
> --------------------------------------------
>
>                 Key: YARN-5325
>                 URL: https://issues.apache.org/jira/browse/YARN-5325
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: YARN-2915
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-5325-YARN-2915.05.patch, 
> YARN-5325-YARN-2915.06.patch, YARN-5325-YARN-2915.07.patch, 
> YARN-5325-YARN-2915.08.patch, YARN-5325-YARN-2915.09.patch, 
> YARN-5325-YARN-2915.10.patch, YARN-5325-YARN-2915.11.patch, 
> YARN-5325.01.patch, YARN-5325.02.patch, YARN-5325.03.patch, YARN-5325.04.patch
>
>
> This JIRA tracks policies in the AMRMProxy that decide how to forward 
> ResourceRequests, without maintaining substantial state across decissions 
> (e.g., broadcast).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to