[
https://issues.apache.org/jira/browse/YARN-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589933#comment-15589933
]
Daniel Templeton commented on YARN-5556:
----------------------------------------
Thanks for working on this, [~Naganarasimha]. Some comments:
* In {{CSQueue}}, the javadoc comment should end with a period: {code} *
remove the specified child queue{code}
* In your message; {{" will be deleted as it as not present in the latest
xml"}}, I'd make a couple changes. Instead of future tense ("will"), I'd make
it present tense ("deleting queue because..."). Also, I'd be more specific
than "latest xml"; give the file name.
* In your message {{" cannot be deleted as one of its children" +
queueHavingAppsRunning + " has apps."}}, I'd say "at least one", and I'd put
the queue name in parentheses or put it at the end after a colon. Depending on
the queue name, the sentence could otherwise be hard to parse. Finally, I'd
say "has active applications" or "has running applications".
* There's a typo in {{"Queue " + queueName + " cannot be deleted as it as "}}
-- as/has
* In {{TestCapacityScheduler}}, after deleting the parent queue, you should
also check to see that the child queue has been deleted.
> Support for deleting queues without requiring a RM restart
> ----------------------------------------------------------
>
> Key: YARN-5556
> URL: https://issues.apache.org/jira/browse/YARN-5556
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Reporter: Xuan Gong
> Assignee: Naganarasimha G R
> Attachments: YARN-5556.v1.001.patch, YARN-5556.v1.002.patch
>
>
> Today, we could add or modify queues without restarting the RM, via a CS
> refresh. But for deleting queue, we have to restart the ResourceManager. We
> could support for deleting queues without requiring a RM restart
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
