[
https://issues.apache.org/jira/browse/YARN-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590106#comment-15590106
]
Sangjin Lee commented on YARN-5751:
-----------------------------------
It is a fair point. However, I'm also not sure if we need to set and store
units for metrics. There is definitely a storage concern.
As [~varun_saxena] said, I would lean towards making the metric names
descriptive. One analogy would be hadoop configuration. There are many
numerical configuration items, and the standard convention is to spell out the
units as part of the configuration names (e.g. "mapreduce.reduce.memory.mb" or
"hadoop.security.groups.cache.secs") although we don't always do a good job of
following this convention.
> Support UNIT for TimelineMetric
> -------------------------------
>
> Key: YARN-5751
> URL: https://issues.apache.org/jira/browse/YARN-5751
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Priority: Critical
>
> ATSv2 allows users to write its metrics using TimelineMetric. But, there is
> no field to tell what is the UNIT of published metric. This is very difficult
> when metrics are read.
> I propose to add UNIT for TimelineMetric so that once user can use this field
> to tell what is the unit of published metric. May be this can be optional
> for few kind or metrics where unit is not required say CPU. But definitely
> there should be a way to set units while publishing the entities.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
