[
https://issues.apache.org/jira/browse/YARN-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590763#comment-15590763
]
Rohith Sharma K S commented on YARN-5751:
-----------------------------------------
Thanks Varun and Sangjin Lee for your thoughts.
Definitely I agree that metric name itself can be self descriptive. Of course
once the contract between writer and reader has been set then there will no
problem. But some Web UI would like to read *as-is* from entity and display
units which will give more clarity.
May be thinking ahead of user upgrade or any other user cases(not known as far
today), let say Tez v1.0 is using ATSv2 where in elapsed time has been
published as seconds. And probably, in Tez1.5 they would like to change from
seconds to minutes. Such cases, reader module(Web UI) need not worry about
reading new field and they would display *directly units*
I will downgrade priority and lets discuss more on use cases.
> Support UNIT for TimelineMetric
> -------------------------------
>
> Key: YARN-5751
> URL: https://issues.apache.org/jira/browse/YARN-5751
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: ATSv2
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Priority: Critical
>
> ATSv2 allows users to write its metrics using TimelineMetric. But, there is
> no field to tell what is the UNIT of published metric. This is very difficult
> when metrics are read.
> I propose to add UNIT for TimelineMetric so that once user can use this field
> to tell what is the unit of published metric. May be this can be optional
> for few kind or metrics where unit is not required say CPU. But definitely
> there should be a way to set units while publishing the entities.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
