[
https://issues.apache.org/jira/browse/YARN-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609030#comment-15609030
]
Eric Payne commented on YARN-2009:
----------------------------------
[~sunilg], I am still analyzing the code, but I do want to point out one
concern that I have.
{{TestProportionalCapacityPreemptionPolicyIntraQueue#testPreemptionWithTwoUsers}}:
In this test, the user limit resource is 30, and {{app3}} has 40 resources.
So, at most, I would expect only 10 resources to be preempted from {{app3}},
which would bring {{app3}} down to 30 resources to match the ULR. Instead, 25
resources were preempted. I feel that
{{FifoIntraQueuePreemptionPlugin#calculateIdealAssignedResourcePerApp}} should
not allow {{tmpApp.idealAssigned}} to be lower than the ULR.
One more thing I noticed during my manual testing is that although the
unnecessary preemption is a lot less, there are cases where it still happens. I
haven't drilled down yet.
> Priority support for preemption in ProportionalCapacityPreemptionPolicy
> -----------------------------------------------------------------------
>
> Key: YARN-2009
> URL: https://issues.apache.org/jira/browse/YARN-2009
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Devaraj K
> Assignee: Sunil G
> Attachments: YARN-2009.0001.patch, YARN-2009.0002.patch,
> YARN-2009.0003.patch, YARN-2009.0004.patch, YARN-2009.0005.patch,
> YARN-2009.0006.patch, YARN-2009.0007.patch, YARN-2009.0008.patch,
> YARN-2009.0009.patch, YARN-2009.0010.patch, YARN-2009.0011.patch,
> YARN-2009.0012.patch, YARN-2009.0013.patch, YARN-2009.0014.patch,
> YARN-2009.0015.patch
>
>
> While preempting containers based on the queue ideal assignment, we may need
> to consider preempting the low priority application containers first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
