[ 
https://issues.apache.org/jira/browse/YARN-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611140#comment-15611140
 ] 

Naganarasimha G R commented on YARN-5697:
-----------------------------------------

Hi [~Tao Jie], 
Had a offline discussion with [~sunilg] even he was also of the same opinion 
that {{rmadmin -replaceLabelsOnNode node1=label1 \[-failOnUnknownNodes\] 
\[~directlyAccessNodeLabelStore\]}} would be the right way to go and we feel 
its not breaking anything .
bq. We should restrict command line format (rmadmin -addToClusterNodeLabels 
-directlyAccessNodeLabelStore x,y will no longer be OK, 
fine with us.
bq. We should modify document and remove -directlyAccessNodeLabelStore.
well modify document anyway you can handle as part of YARN-5270 (as per the 
conclusion here) but remove {{-directlyAccessNodeLabelStore}} no need to take 
here, IIRC there is already a jira for it.

Thoughts ? cc/ [~wangda]


> Use CliParser to parse options in RMAdminCLI
> --------------------------------------------
>
>                 Key: YARN-5697
>                 URL: https://issues.apache.org/jira/browse/YARN-5697
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.8.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>         Attachments: YARN-5697.001.patch, YARN-5697.002.patch, 
> YARN-5697.003.patch
>
>
> As discussed in YARN-4855, it is better to use CliParser rather than args to 
> parse command line options in RMAdminCli.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to