[
https://issues.apache.org/jira/browse/YARN-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15620294#comment-15620294
]
Naganarasimha G R commented on YARN-5697:
-----------------------------------------
Hi [~wangda],
Thanks for sharing your views, me and [~sunilg] had a discussion about this
during the bug bash, we both were of the opinion it would be better to handle
{{node label mapping}} as {{cliParser.getOptionValues}} of
{{-replaceLabelsOnNode}} than handling just the additional arguments because,
# like any other commands it would be better to have it as OptionValues than
just additional arguments of the command.
# This would help in parsing the command cleanly in the code
# {{-directlyAccessNodeLabelStore}} hardly used by anyone and is already
deprecated. no where in the documentation we have specified that it can appear
in between {{-replaceLabelsOnNode}} and {{node label mapping}} . And in terms
of breaking compatibility, actually it doesn't break anything but just that the
way command arguments are positioned differs.
# ??If this patch goes to branch-2.8 (better not in my opinion), we have to
keep this option?? Well problem is once we do not have this in 2.8, then its
like we allow {{-failOnUnknownNodes}} to come between the
{{-replaceLabelsOnNode}} and {{node label mapping}} which i feel i
inappropriate. and later we will not be able to modify it as again we will
break the compatibility (if we assume to this placing as incompatible change).
> Use CliParser to parse options in RMAdminCLI
> --------------------------------------------
>
> Key: YARN-5697
> URL: https://issues.apache.org/jira/browse/YARN-5697
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Tao Jie
> Assignee: Tao Jie
> Attachments: YARN-5697.001.patch, YARN-5697.002.patch,
> YARN-5697.003.patch
>
>
> As discussed in YARN-4855, it is better to use CliParser rather than args to
> parse command line options in RMAdminCli.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
