[
https://issues.apache.org/jira/browse/YARN-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613702#comment-15613702
]
Daniel Templeton commented on YARN-4907:
----------------------------------------
Thanks, [~yufeigu]. One comment: your while-if-break statements can be
simplified. For example:
{code}
while (true) {
if (timeWaiting >= TIMEOUT_MS_FOR_CONTAINER_AND_NODE) {
break;
}
{code}
should be
{code}
while (timeWaiting < TIMEOUT_MS_FOR_CONTAINER_AND_NODE) {
{code}
There's another in {{waitForNewAMToLaunchAndRegister()}}.
> Make all MockRM#waitForState consistent.
> -----------------------------------------
>
> Key: YARN-4907
> URL: https://issues.apache.org/jira/browse/YARN-4907
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Labels: oct16-medium
> Attachments: YARN-4907.001.patch
>
>
> There are some inconsistencies among these {{waitForState}} in {{MockRM}}:
> 1. Some {{waitForState}} return a boolean while others don't.
> 2. Some {{waitForState}} don't have a timeout, they can wait for ever.
> 3. Some {{waitForState}} use LOG.info and others use {{System.out.println}}
> to print messages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
