[ https://issues.apache.org/jira/browse/YARN-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616010#comment-15616010 ]
Daniel Templeton commented on YARN-4907: ---------------------------------------- Can we simplify this one as well? {code} int timeWaiting = 0; while (app.getAppAttempts().size() != attemptSize) { if (timeWaiting >= TIMEOUT_MS_FOR_ATTEMPT) { break; } {code} > Make all MockRM#waitForState consistent. > ----------------------------------------- > > Key: YARN-4907 > URL: https://issues.apache.org/jira/browse/YARN-4907 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager > Reporter: Yufei Gu > Assignee: Yufei Gu > Labels: oct16-medium > Attachments: YARN-4907.001.patch, YARN-4907.002.patch > > > There are some inconsistencies among these {{waitForState}} in {{MockRM}}: > 1. Some {{waitForState}} return a boolean while others don't. > 2. Some {{waitForState}} don't have a timeout, they can wait for ever. > 3. Some {{waitForState}} use LOG.info and others use {{System.out.println}} > to print messages. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org