Am 31.05.21 um 20:12 schrieb Will Godfrey:
When you have the new code stabilised enough can you put some info in
dev_notes please?
On 27.06.2021 19:40, Ichthyostega wrote:
I will look into that next.
Hi Kristian,
Hi Will,
meanwhile I've tested and rounded up my changes proposed for the Yoshimi
application to support automated testing. IMHO matters are settled down
sufficiently to start discussing and reviewing my changes and additions.
https://github.com/Yoshimi/yoshimi/compare/master...Ichthyostega:testing
For me it's the first time to add something substantial to the Yoshimi CLI
and I'm not sure my additions fit in properly and follow the expected standards.
Regarding sound synthesis, I have slightly rearranged some aspects regarding
the reseeding within OscilGen. I consider these changes equivalent and without
impact on the actual sound calculation. Most notably I have moved down the point
where we draw the seed for the harmonic PRNG in OscilGen::get, so it happens now
only /after/ we check for parameter changes and possibly reinvoke prepare().
Indirectly this avoids leaking old random state after re-seeding the Synth.
At the places I touched, I also did some obvious code clean-up; most notably
I renamed the thread variables in main (thr -> threadGui) and I deleted some
already commented out (and dangerous) duplicated code in LV2_Plugin/Config.cpp,
while I modified/extended the other copy of the same code in Config.cpp
The new commandline option '--null' instructs Yoshimi not to probe for any
sound or MIDI connection, but immediately use the "Null backend". My intention
is to use this for running Yoshimi under Docker in an controlled environment.
This is tested and works on a regular install, but it does not yet work in
a Docker container, since Yoshimi tries to connect to the X-Windows system
even when launched with --no-gui (However, I'd like to postpone that issue
and look into it separately later, since I feel it more pressing to get
ahead with the Testsuite itself)
Please have a look at dev_notes/Automated_Testing_Support.txt
hope this developer documentation is sufficient to understand my changes.
Cheers,
Hermann
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
