On 08.11.2021 13:20, Will Godfrey wrote: > I think this is now complete and looking pretty solid. As soon as I set midi > learn itself to report direct comparisons a number of mistakes showed up which > I've now put right. I'll probably merge it back into master later this week, > although it still uses the old numbers. > > My plan is eventually to no longer use or even load the old numbers, but still > save them - for at least some partial backward compatibility. > > I've also made more controls learnable, and there are a few more I'll add. > This > is now practical thanks to Kristian's work making so many of these real-time > :) > > Another thing I've done is getting a bit more consistency in the names, along > with some more meaningful ones. Text2Data recognises both old and new words. > If I can get hold of older .xly files from anyone, and/or there are more name > changes, these can easily be added in.
I don't have any really old ones (and I thought staying up to date was good 🙂), but I'll certainly look out for changes in response on the ones I do use. > The parsing (while still quite complex) is much cleaner than both the CLI and > the GUI sends. It doesn't send a whole lot of parameters all over the place > but > just the text line and the control block both by reference. The various > sections > fill in parameters as they are found and trim the text line. This also means > functions can peek at the control block to see what is already set. I'm glad to see this improved. Do you also plan changes in how the CLI and GUI sends things? I'm asking since it could influence things when I get around to adding MIDI learn to the curves. > I've found a number of errors in both Data2Text.cpp and MidiLearn.cpp and have > corrected them. MidiLearn.cpp is a nightmare to navigate. > If I ever find out who... OH! :@) Hehe, be careful with "git blame", it can backfire! -- Kristian _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel