On Mon, 8 Nov 2021 22:50:32 +0100
Kristian Amlie <krist...@amlie.name> wrote:


>> If I can get hold of older .xly files from anyone, and/or there are more name
>> changes, these can easily be added in.  
>
>I don't have any really old ones (and I thought staying up to date was
>good 🙂), but I'll certainly look out for changes in response on the
>ones I do use.

I don't need them now - the answer was staring me in the face. Version 1.5.1
was the first that has mlearn complete. It also has (for its time) a complete
copy of /dev_notes/Yoshimi Control Numbers.ods
All I had to do was look up the control numbers and plonk them into current
mlearn files {DOH}. Slightly more tedious was to look through InterChange.cpp
for changed names. That section was later split out into Data2Text.

>> The parsing (while still quite complex) is much cleaner than both the CLI and
>> the GUI sends. It doesn't send a whole lot of parameters all over the place 
>> but
>> just the text line and the control block both by reference. The various 
>> sections
>> fill in parameters as they are found and trim the text line. This also means
>> functions can peek at the control block to see what is already set.  
>
>I'm glad to see this improved. Do you also plan changes in how the CLI
>and GUI sends things? I'm asking since it could influence things when I
>get around to adding MIDI learn to the curves.

I'd like to look at both of these at some point. The GUI is the oldest, and
most fragmented but has to work in reverse from leaf to top level, where
everything else works from top level to leaf. Although I'm now sure the mlearn
parsing is 99% safe I've still got a lot to do on the code itself. I
think it could be much more efficient (and faster). I'd rather not have too many
balls in the air at once!

-- 
Will J Godfrey
https://willgodfrey.bandcamp.com/
http://yoshimi.github.io
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.


_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel

Reply via email to