On Mon, 15 Nov 2021 23:10:08 +0100 Ichthyostega <p...@ichthyostega.de> wrote:
>> On Mon, 15 Nov 2021 05:41:04 +0100 Ichthyostega <p...@ichthyostega.de> >> wrote: >>> With the change, calling "APPLY" from a CLI script does no longer invoke >>> PADnoteParameters::applyparameters() > > >Am 15.11.21 um 10:45 schrieb Will Godfrey: >> Found the cause of this. APPLY now needs a value of 1, whereas previously >> any value would set it, this presented a problem with MIDI learn. > >> ..... As your script is still at waveform level, the command was still >> sending a zero, so was ignored. This is easily fixed of course, but do you >> want me to do so now, or wait till you've checked the anomaly you've seen? > >No problem, just proceed with the fix. I do my tests on a private branch >anyway. OK Done now. >>> ... In fact, the test /should/ still be fine. This is, because the >>> TestInvoker re-seeds the SynthEngine, and then explicitly invokes >>> PADnoteParameters::applyparameters() for all active PADSynth voices. Thus, >>> after the "execute" from the CLI script, in both cases the wavetable is >>> re-built. > >> When you say this is set explicitly how is this done? I remember (vaguely) >> when I originally made this available to the CLI I had to jump through hoops >> to get the CLI to be able to do this correctly :( > >It is done more or less brute force. >The TestInvoker is triggered from CLI, sends a shutdown message to the >regular SynthEngine and waits for synth->audioOut == _SYS_::mute::Idle > >After that, the normal SynthEngine and audio backend is basically out of >the way. The TestInvoker can then directly call into the SynthEngine code, >first to reseed, then to calculate the test sound. Deliberately without any >multitheading or message passing, only the bare bone sample computations. > >When done, the CLI thread terminates and main unwinds. OK. Seems fine to me. -- Will J Godfrey https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song. _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
