Am 09.12.21 um 10:56 schrieb Kristian Amlie:
At some point, I'm not exactly sure when, I think the reseeding of the RNG must have stopped working. I'm getting some significant differences in PADsynth:
- "features/BasicPAD.test": Performed; detect Δ 7.16249dB(RMS)
Hi Kristian, indeed, such a result is an obvious indication that the test didn't start with the same / pristine state. Due to phase randomisation you then get a completely different waveform, which sounds similar, but has sonic fluctuations slightly shifted. There is a not yet resolved problem lurking somewhere in the code base, causing some state to leak through PADSynth (re)initialisation. During the last development cycle, as a follow-up of the MIDI learn revamp, Will improved the handling of the PADSynth apply() message. This introduced a bug (apply() didn't happen under some circumstances), which Will quickly resolved thereafter.
I'm running with with the Yoshimi power branch, and latest yoshimi-test master branch.
Thus the first thing we need to ensure is that we all run from the same code base. I generated the reference waveform with a Yoshimi built from the latest release (2.1.2.2). Can you please repeat your test with a build from that release (and if any differences remain, then please post the SHA1 of the exact commit your build is based on)?
Could it be reseeding not working? I haven't found where this actually happens from yoshimi-test, so maybe you could point me to it?
Reseeding is initiated from the "TestInvoker" within yoshimi itself. Look at Misc/TestInvoker.h, line 315 SynthEngine::setReproducibleState(seed) not only reseeds the PRNG, but also explicitly forces rebuilding of PADSynth wavetables. -- Hermann _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
