On Mon, 13 Dec 2021 22:35:37 +0100 Kristian Amlie <krist...@amlie.name> wrote:
>On 13.12.2021 14:27, Will Godfrey wrote: >> On Fri, 10 Dec 2021 05:31:23 +0100 >> Ichthyostega <p...@ichthyostega.de> wrote: >> >>> Am 09.12.21 um 10:56 schrieb Kristian Amlie: >>>> At some point, I'm not exactly sure when, I think the reseeding of the RNG >>>> must have stopped working. I'm getting some significant differences in >>>> PADsynth: >>> >>>> - "features/BasicPAD.test": Performed; detect Δ 7.16249dB(RMS) >>> >>> >>> Hi Kristian, >>> >>> indeed, such a result is an obvious indication that the test didn't >>> start with the same / pristine state. Due to phase randomisation you >>> then get a completely different waveform, which sounds similar, but >>> has sonic fluctuations slightly shifted. >>> >>> There is a not yet resolved problem lurking somewhere in the code base, >>> causing some state to leak through PADSynth (re)initialisation. During >>> the last development cycle, as a follow-up of the MIDI learn revamp, >>> Will improved the handling of the PADSynth apply() message. This >>> introduced a bug (apply() didn't happen under some circumstances), >>> which Will quickly resolved thereafter. >>> >>>> I'm running with with the Yoshimi power branch, and latest yoshimi-test >>>> master branch. >>> >>> Thus the first thing we need to ensure is that we all run from the >>> same code base. I generated the reference waveform with a Yoshimi >>> built from the latest release (2.1.2.2). Can you please repeat your >>> test with a build from that release (and if any differences remain, >>> then please post the SHA1 of the exact commit your build is based on)? >>> >>>> Could it be reseeding not working? I haven't found where this actually >>>> happens from yoshimi-test, so maybe you could point me to it? >>> >>> Reseeding is initiated from the "TestInvoker" within yoshimi itself. >>> Look at Misc/TestInvoker.h, line 315 >>> SynthEngine::setReproducibleState(seed) not only reseeds the PRNG, >>> but also explicitly forces rebuilding of PADSynth wavetables. >>> >>> -- Hermann >> >> Just want to add I'm getting no such problem here with the current master, >> nor >> the new padthread branch - both come out at -119.11dB > >That's so odd, I still haven't figured out why this happens. By checking >out 2.1.2.2 I got slightly better results, but the BasicPAD still sits >at -13dB difference. > >Just to rule out that this has anything to do with the randomness, can >one of you guys try to apply this patch, and then rerun the tests? Just tried that here, I get very similar but not identical results. file attached. Incidentally, you could have just enabled NORANDOM :) Line 34 in globals.h -- Will J Godfrey https://willgodfrey.bandcamp.com/ http://yoshimi.github.io Say you have a poem and I have a tune. Exchange them and we can both have a poem, a tune, and a song.
- "features/BasicADD.test": Performed; detect Î -65.0338dB(RMS) - "features/BasicPAD.test": Performed; detect Î 11.5211dB(RMS) - "features/BasicSUB.test": Performed; detect Î 28.2187dB(RMS) - "features/filter/AnalogFilter_BandFreqDown.test": Performed; detect Î -75.2928dB(RMS) - "features/filter/AnalogFilter_BandFreqMid.test": Performed; detect Î -93.9209dB(RMS) timing OK - "features/filter/AnalogFilter_BandFreqUp.test": Performed; detect Î -111.785dB(RMS) - "features/filter/AnalogFilter_BandTrack1.test": Performed; detect Î -69.832dB(RMS) timing OK - "features/filter/AnalogFilter_BandTrack2.test": Performed; detect Î -71.029dB(RMS) - "features/filter/AnalogFilter_BandTrack3.test": Performed; detect Î -81.0093dB(RMS) - "features/filter/AnalogFilter_BandTrack4.test": Performed; detect Î -69.7621dB(RMS) - "features/filter/AnalogFilter_BandTrack5.test": Performed; detect Î -80.9457dB(RMS) - "features/filter/AnalogFilter_BandTrack6.test": Performed; detect Î -75.7662dB(RMS) - "features/filter/AnalogFilter_BandTrackZero.test": Performed; detect Î -74.9577dB(RMS) - "features/filter/AnalogFilter_HShelfFreqDown.test": Performed; detect Î -86.2158dB(RMS) - "features/filter/AnalogFilter_HShelfFreqMid.test": Performed; detect Î -104.643dB(RMS) - "features/filter/AnalogFilter_HShelfFreqUp.test": Performed; detect Î -119.58dB(RMS) - "features/filter/AnalogFilter_HShelfQwide.test": Performed; detect Î -106.701dB(RMS) - "features/filter/AnalogFilter_High2FreqDown.test": Performed; detect Î -76.645dB(RMS) - "features/filter/AnalogFilter_High2FreqMid.test": Performed; detect Î -95.3746dB(RMS) - "features/filter/AnalogFilter_High2FreqUp.test": Performed; detect Î -111.862dB(RMS) - "features/filter/AnalogFilter_High2Qwide.test": Performed; detect Î -99.2553dB(RMS) - "features/filter/AnalogFilter_LShelfFreqDown.test": Performed; detect Î -66.1637dB(RMS) - "features/filter/AnalogFilter_LShelfFreqMid.test": Performed; detect Î -85.7217dB(RMS) timing OK - "features/filter/AnalogFilter_LShelfFreqUp.test": Performed; detect Î -107.105dB(RMS) - "features/filter/AnalogFilter_LShelfQwide.test": Performed; detect Î -91.0178dB(RMS) - "features/filter/AnalogFilter_Low2FreqDown.test": Performed; detect Î -77.005dB(RMS) - "features/filter/AnalogFilter_Low2FreqMid.test": Performed; detect Î -95.6356dB(RMS) timing OK - "features/filter/AnalogFilter_Low2FreqUp.test": Performed; detect Î -115.544dB(RMS) - "features/filter/AnalogFilter_Low2Qwide.test": Performed; detect Î -102.147dB(RMS) - "features/filter/AnalogFilter_PeakQmid.test": Performed; detect Î -78.4219dB(RMS) - "features/filter/AnalogFilter_PeakQnarrow.test": Performed; detect Î -77.9627dB(RMS) timing OK - "features/filter/AnalogFilter_PeakQwide.test": Performed; detect Î -79.1629dB(RMS) timing OK - "features/filter/AnalogFilter_StopQmid.test": Performed; detect Î -96.103dB(RMS) timing OK - "features/filter/AnalogFilter_StopQnarrow.test": Performed; detect Î -88.9779dB(RMS) - "features/filter/AnalogFilter_StopQwide.test": Performed; detect Î -99.5761dB(RMS) - "features/filter/SVFilter_LowQnarrow.test": Performed; detect Î -108.813dB(RMS) - "features/oscil/Wavetable_NoisePink.test": Performed; detect Î 386.222dB(RMS) timing OK - "features/oscil/Wavetable_NoiseSpot.test": Performed; detect Î 386.592dB(RMS) timing OK - "features/oscil/Wavetable_NoiseWhite.test": Performed; detect Î 392.602dB(RMS) timing OK
_______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
