On 13.04.2023 19:14, Will Godfrey wrote:
This latest deep dive I'm on has uncovered yet another anomaly :(
All the 0 to 127 value ranges as well as being received from MIDI as chars are
also saved in XML files as chars. Added to which the original defaults
are set as chars.
However, internally many of them are handled as floats (or were originally).
Unaware of this, over the years I've changed some of the GUI controls to chars
for (what I believed was) consistency. I think others have too on occasion -
leastways there are some I don't recognise.
The point is, (even without my changes) with all of these you were NEVER able
to recover exactly what you'd set! That goes right back to Zyn 2.2.1
Now while going through the limits stuff I can dig out and correct mistaken
changes but what do we do about the XML files?
Admittedly I've never looked into the details, but I've been pondering
about this in the past, and I naively assumed that we can distinguish
chars from floats in the XML by looking at whether it has a decimal
point. So I reckon we could just start storing all floats like this.
This should even be backwards compatible; the old client should be able
to load the floats, albeit at a somewhat reduced accuracy.
But again, this is my naive idea, I've not actually tried this.
--
Kristian
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
