Am 12.05.23 um 23:56 schrieb Will Godfrey:
Aaand we come screeching to a halt :( I ran the testsuite and i failed really badly on the SVfilter tests.
Unfortunately, I didn't see your latest Mail message in time. And additionally I made the mistake first to do the packaging work and only after the packages were pushed out, I run the testsuite and saw the failed cases. Anyway, the good news is that by a quick check there is no obvious *audible* difference. From looking closely at the waveforms, I get the impression that the filter also behaves similar, and we've just gotten a minute phase shift, which is most notably at the lower frequencies. Filters can be quite nasty beasts and amplify even the tiniest changes. Incidentally, also the AnalogFilter test cases show differences, albeit very small and close to rounding errors. Thus I'd say, there is no reason to raise a big glaring alarm, rather we should take our time to do a closer analysis. If it's really a "number dust" error leaking into some frequency parameter, this would be something we just have to admit (and which has no practical consequences). I had similar changes with my "Padthread" rework (where a very minute numerical error in the frequency domain caused a significant deviatation after FFT, but also in practice the change was not audible). -- Hermann _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
