On 17.09.24 16:15, Will Godfrey wrote:
Not a big issue, but I'm wondering if (in CMakeLists.txt) we should make this
compiled by default. I always have it enabled here.
Indeed, do we need to make it optional at all? The reporting is already user
switchable, and no doubt some people have been confused when it seems to do
nothing, not having been compiled in.
Accessing the system clock always costs some performance; it is an overhead
comparable to an ordered read from an atomic variable, so it's not negligible.
Thus I would argue that it is not justified to put such a merely diagnostic
feature on such a critical code path by default.
Maybe it is in fact not relevant or it goes alongside with existing
synchronisation overhead. But the point I'd make is, it is hard to prove
such an added feature really does /not/ matter. Think of different audio
systems, plugin hosts, different platforms. So without an extended
investigation, we're just guessing and in such a situation I'd err to the
safe side and not add anything to a hot path which is not strictly required.
-- Hermann
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
