On Wed, 18 Sep 2024 01:39:34 +0200
ichthyo <p...@ichthyostega.de> wrote:
>On 18.09.24 00:10, Will Godfrey wrote:
>>>> Another possibility that might be practical is to use the switch setting
>>>> to enable/disable the timing code. That way, the only overhead would be
>>>> a couple of bool tests.
>>
>> DOH!
>>
>> Just actually looked at the code. The switch is already there! I've just
>> modified it slightly so it encloses both the initial time call, as well as
>> the comparison, so I've made it permanently active and removed the build
>> option.
>
>Its cool to get rid of a build option!
>
>Where can this feature now be switched off? Probably I am looking
>at the wrong place, but in the "Switches" tab I can find only a checkbox
>for the variable `Config::showTimes`. Moreover, are you referring to
>REPORT_NOTE_ON_TIME or to REPORT_NOTES_ON_OFF ?
>The latter seems to output a report only on the CLI.
It's REPORT_NOTE_ON_TIME in the code.
The switch is the one marked 'Log Load Times'. It is shared with loading
instruments. This might not be ideal, and maybe we should have a separate
switch, although I found it interesting to see the two reported together..
>>> Another tiny observation: in the "Main Settings" tab of the settings
>>> dialog, the drop-down list at bottom "Mixer Pannel Layout" is empty, even
>>> while the actual setting (one row with 16 strips) is retained correctly.
>>
>> I'm not seeing this here. However, if you just nudge the mixer window size,
>> does it then correctly show?
>
>Rescaling the settings window does not change anything. The current state is
>just not selected for this FL_choice.
>
>Looking at the one before, which is the instrument format, matters are
>different. There we immediately also select the current setting in make_window
>
> o->add("Legacy");o->add("Yoshimi");o->add("Both");
> o->value(synth->getRuntime().instrumentFormat - 1);
>
>The next one, the FL_coice "PanelLayout" does only populate the values,
>but does not select the current one. If I select the other option, the
>Panel layout changes, but the choice is again not selected in the Config-UI.
>
>Looking into the code, then the other one I use for comparison here, the
>"instrument" type, has a handling in returns_update.
>
>How is the panel layout persisted?
>I can see that in my config in Git from the previous version, there
>used to be a setting in the instance Config, called "single_row_panel"
>This setting seems to be gone since last release. The information
>seems only to be somehow retained in the window layout files. There
>seems to be GUI variable "MasterUI::paneltype", which is compared
>to several values (type == 1 and type == 2 but in MasterUI::Init()
>we set type = 5. And I can find no code that accesses this
>panel type to select the appropriate entry in the FL_select.
It never used "single_row_panel", so I removed it. The layout is stored in the
window position/size data (.config/yoshimi/windows/). It is purely a GUI feature
and has no effect on any running matters.
--
Will J Godfrey
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
