On 13.01.2025 09:43, Will Godfrey wrote:
On Mon, 13 Jan 2025 08:17:01 +0100
Kristian Amlie <krist...@amlie.name> wrote:
Alright, final conclusions here:
I will implement Omni mode as a checkbox, and it gets saved in the same
section as the other mixer elements (the state). In other words
instrument files are unaffected, which I think makes sense.
OK.
I will drop the MIDI part of the implementation, both because there is
low demand for it, and because we have no clear answer to the
temporary-vs-permanent nature of this setting, if it were to respond to
CC 124 and 125. However, since I'm making a separate checkbox, and not
merely an extra choice in the Channels list, we are remaining MIDI
compatible, and can choose to implement it later.
Actually, On further thought I think MIDI should be included. I have two
hardware synths, and checking the user guides (which I still have), both have
this as an option that is disabled by default.
Could you cover all possibilities by making it a three state control?
On,
Enable via MIDI
OFF
That's a good idea. That answers the temporary-vs-permanent question: It
will always be temporary when MIDI-enabled.
I would then suggest it should be put in Settings-> MIDI CCs.
Move the 'Enable Extended Program Change' pair up and put the new control
between it and 'Enable Incoming NRPNs'
>
All these entries are stored in the Config file, which would be part of a state
one as well.
Ok.
I had to test this a bit before I replied to make sure it would work. In
principle I think it will, but there seems to be a bug in this area:
When I use the menu to load the state, the config is not respected. It
appears to be due to the sessionStage variable being in the wrong state,
so it doesn't enter the "InProgram" section in
Config::extractConfigData. Is this intentional?
--
Kristian
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
