On 23.01.25 23:40, Will Godfrey wrote:
Like that LV2 at startup would only see the hard defaults, and would not save anything to the main config or instance files, but would be relying on: SynthEngine::getalldata( SynthEngine::putalldata(
Hi Will, see at the end of my other mail. Where I've explained the idea with the hash-IDs. The point is: we need to know if a LV2 host *must* (by the standard) use this mechanism. Which is equivalent to always starting Yoshimi with a state file and at the end saving that state file. Because, in that case, the instance config is always overwritten anyway It would not resolve the corruption problem Kristian described though. Because that rests on a dangerous setting leaking from the defaults into a new instance and from there into the patch-state data the host stores and publishes back. Besides that, there is also the problem with the Window layout files. For users with high resolution displays, these are crucial. We'd have to find a way also to pick up some default window layout whenever we are in the "new instance" case. Your change (and the similar one pondered by me) basically amount to always making LV2 plugin instances go into the "new instance" case. We must be sure that all relevant hosts do indeed send the patch-state data. And of course, we'd have to do the change in a way that it also covers other stuff like the window files. That is, if anything, I'd propose to handle it at the point where the config location is resolved, ideally at a single and easy to sport central location, and rather not hook into some implementation functions deep down without understanding all the consequences. -- Hermann _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
