On 08.04.2025 18:06, Will Godfrey wrote:
On Tue, 8 Apr 2025 14:21:56 +0200
Kristian Amlie <krist...@amlie.name> wrote:
Alright, finally, I have now put up a pull request at [1] with the Omni
mode feature. I have tested the functionality, the UI and the ability to
use MIDI CC messages to turn it on and off. I have also tested that it
works on the Zynthian hardware unit, which is why I started this whole
discussion to begin with. And it works like a charm! More info about
that in [2].
What I have not tested is the CLI. Will, is it straightforward for you
to test it? It's just a matter of turning on and off Omni mode itself,
as well as the Enable Omni Mode Change setting in the config.
This works correctly, but you've got the wording reversed. It should be ON,
{other}, indicating that only 'ON' will switch it on and anything else
(including just Return) will switch it off.
I've sorted that myself.
Oops, thanks! 😄
Another detail is that sending the MIDI message doesn't update the display.
However we're rather inconsistent here, some controls do, some don't I keep
meaning to sort that out :(
This is intentional. It came about after a difficult discussion about
whether the state should be changed by the MIDI message in a way that
would save or not. In the end we decided not to, and therefore the two
mechanisms are completely separate. Whichever one was changed last is
the one which is in effect (the tooltip also mentions this). Only the
one on the panel is saved.
This is similar to how several of the other standard CC messages work in
Yoshimi. For example CC 1 will change frequency LFO depth, but will not
actually change any parameters (unless it is also MIDI learned). It is
being handled "on top of" the parameters.
A few more comments below.
[1] https://github.com/Yoshimi/yoshimi/pull/223
[2] https://gitlab.com/kramlie/zynthian-yoshimi
You realise, of course that I now have to update the User Guide, and Advanced
Reference Manual!
Oh, I can take care of that if you want. Otherwise it's a half done job,
and I don't want to leave a mess! 🙂
The first won't need much apart from new images, but I'm wondering how much
detail we should put in the latter, especially your notes about interfacing
with Zynthian. We've not made detailed reference to much other software up
till now
As much as I like both, I think that hardware recommendations do not
really belong there.
I'm considering writing a blog post about the Zynthian/Yoshimi
combination on my personal blog later though, to raise the profile a
little bit. Right now it's quite hard to find by searching.
On 07.02.2025 18:44, Will Godfrey wrote:
On Wed, 5 Feb 2025 15:30:30 +0100
Kristian Amlie <krist...@amlie.name> wrote:
Did
you remember to also move the red warning background patch? Can't have legato
and drum mode).
I did not! I'll make sure this is done.
Not that I know anyone else who ever forgot to adjust these backgrounds :P
After looking at it, I think the background is just the same label,
isn't it? The one that says "Mode"? At least I could not find anything
else, and it does display the warning color correctly, AFAICS.
I'd changed that and forgot! Previously it was a separate patch behind the
control.
👍
--
Kristian
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
