Hi Yoshimi-developers,
right now I'm looking into the issues with startup configuration,
which were brought to our attention by Johannes; at that time he was
preparing the new DEB package and -- since Debian/Trixie switched
to FLTK 1.4, he also tried to build with FLTK 1.4 and did not notice
any direct issues in the GUI related to FLTK 1.4
I can confirm that, I'm on Trixie since last March and also did not
notice any direct issues (letting aside that deprecation also pointed
out by will in another thread here in this mailinglist recently).
However, Johannes noticed some strange behaviour with the handling
of the "show GUI setting".
I'll start with the obvious / small stuff: The compressed Config file.
Looking into the Code:
- the old solution prior to my refactoring this spring
generally handled the XML-Compression from within the XML handling
code, and for that it needed to access the config.
But there was also an additional override flag
Notably this override was *only* set for the Master-config.
- during my refactorings, I extracted that handling and passed
the compression setting as parameter from above, when invoking
the store to XML.
Notably my mistake was to treat *all invocations uniformly*,
missing the exception present for the Master-Config
This is trivial to fix -- however, I'd propose *also* to store
the instance-config uncompressed from now on. With this I fully
agree with Johannes: there does not seem to be any good reason
to compress something that important as a the config files.
Even more so since even an experienced user might take a look
into that file eventually, while most non-developers will not
take the hurdle to gzip-uncompress a config file.
Thus: *proposed change*
- store the master-config always uncompressed again
- additionally also store the instance-config uncompressed
What do you think?
-- Hermann
_______________________________________________
Yoshimi-devel mailing list
Yoshimi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
