On Sun, 28 Sep 2025 18:49:58 +0200 ichthyo <[email protected]> wrote:
>> On 26.09.25 15:13, Will Godfrey wrote: >>> Confirmed fixed for the main and mixer windows, but still not correct in >>> the bank window - slightly less of a problem actually. > >On 26.09.25 18:08, ichthyo wrote: >> Indeed I noticed that too, yesterday evening, but I can not yet explain it. > >After looking a bit around, it's pretty much obvious what is going on here. >The logic was implemented two times, for the refresh() and the draw() function. > >The different label colour is set only in the refresh() handler, >but the draw() is invoked much more frequently, and so the change is >overwritten immediately. > >Furthermore, the refresh() used `gen_text` for the legacy case, >while the draw() used `bank_text` for both cases. > >I think it should always be `bank_text` for legacy or `yoshi_ins_typ` > >See my proposed patch, attached to this message > > >you can directly apply this patch from the git tree with > > >git am BugFix-bank-label-colour-handled-inconsistently.patch Thanks a lot Hermann. This works quite correctly now. Apart from anything else, I think this sort of mistake is probably due the incremental development over quite long periods. -- Will J Godfrey _______________________________________________ Yoshimi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
