On Thu, 2012-08-16 at 17:37 +0200, Zdeněk Pavlas wrote:
> The mirror's 'kwargs' hash is used to update the grab request,
> and it was overriding the global limit. Using different names
> is also much clearer.
Is there anyway we can fix this name collision while being compatible?
If there is no way, can you at least add "conflicts: other < ver" to
both specfiles with a comment about why?
> ---
> yum/yumRepo.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/yum/yumRepo.py b/yum/yumRepo.py
> index 35182d3..0f9ac55 100644
> --- a/yum/yumRepo.py
> +++ b/yum/yumRepo.py
> @@ -541,7 +541,7 @@ class YumRepository(Repository, config.RepoConf):
> if mc > 0:
> url = {
> 'mirror': misc.to_utf8(url),
> - 'kwargs': { 'max_connections': mc },
> + 'kwargs': { 'max_mirror_connections': mc },
> }
Also, if we have to change the name this one implies something
different from what you want (to me).
This is the "pass through" of the per. host metalink "maxconnections"
data, right? (hence the name, I guess :). The new name implies that it's
some global that only "applies to mirrors" or something.
I'm trying to think of something better without going completely insane
length wise best is like "host_connection_limit" ... any other ideas?
_______________________________________________
Yum-devel mailing list
[email protected]
http://lists.baseurl.org/mailman/listinfo/yum-devel
