On Fri, 2012-08-17 at 05:34 -0400, Zdenek Pavlas wrote: > > > The mirror's 'kwargs' hash is used to update the grab request, > > > and it was overriding the global limit. Using different names > > > is also much clearer. > > > > Is there anyway we can fix this name collision while being > > compatible? > > - opts.max_connections > + default_grabber.opts.max_connections
Doesn't that change the option context though? (so we're moving from the options for this instance to the options for the global default_grabber instance). > In fact, this was probably enough to fix this issue :) > But there's another: > > 1) We run _mirror_try() once for the 1st mirror. > 2) Here we mix mirror's kwargs into the request's kwargs. > 3) Multi downloader does not "undo" 2) when moving to next mirror, > neither does it use any kwargs from the next mirror. > > The following patch should fix this, too: From what I understand everything looks great apart from the default_grabber line (maybe you meant self.opts)? Maybe I'm just not understand that line though :). _______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
