On 06-08-21 22:33 Maxime Austruy wrote:

> zd_chip_led_status is only used by zd_chip_led_flip which itself is not
> used, yet. While it's not vital to fix bugs in those functions, it is
> nice to have a clean code base, so please consider this patch for
> inclusion. It addresses the following problems:
>  . if read_led_reg fails or if the callsite of zd_chip_led_status passes
>    a bogus status, we return with chip->mutex locked,
>  . zd_chip_led_status returns the wrong return value when successful,
>  . zd_chip_led_flip doesn't properly check the return value of
>    zd_chip_led_status.
> 
> Signed-off-by: Maxime Austruy <[EMAIL PROTECTED]>

Thank you Maxime. However I've fixed it on my own and I support
blinking now. This patch contains comparable code:

http://www.deine-taler.de/git/?p=zd1211.git;a=commitdiff;h=d5cb64797be22f083fdbb34eb6aadd886b26ab03;hp=4def8e849c5e67a69a606e74ebae85c725c4e0ff

Regards,

Uli

-- 
Uli Kunitz

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Zd1211-devs mailing list - http://zd1211.ath.cx/
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/zd1211-devs

Reply via email to