Hi Hin-Tak,

one of my chief problems was that I was not at all able to get compat-wireless 
to work with this rather ancient kernel version. The driver file zd_rf_uw2453.c 
added in the patch is indeed taken from a recent version of compat-wireless 
itself.

Also, I can't really see that the issues I've mentioned got fixed in 
compat-wireless either. I've seen many people still reporting problems with 
this now and then.

My main motivation for the changes were to build the zd1211rw.ko module which I 
can now load into a proprietarily-modified kernel on an embedded system (I 
can't simply build a new kernel for the device since I lack the BSP).

The white space change was unintended; the debug statements are inserted at 
points were people seem to get in trouble.

Sören

> --- On Fri, 7/8/09, "Sören Wellhöfer" <soeren.wellhoe...@gmx.net> wrote:
> 
> > While adding support for the
> > TL-WN322G wireless usb adapter on an embedded system I
> > devised a patch to be applied against the 2.6.22.x kernel to
> > make it work.
> > 
> > It basically integrates support for the uw2453 chip into
> > the zd1211rw driver framework of mentioned kernel and fixes
> > a few common issues associated with the device. 
> > 
> > Among the problems taken care of are those which are
> > described in this mailing list under the following
> > subjects:
> >     
> >     * [zd1211-devs] tp-link WN322G
> >     * [zd1211-devs] zd1211 on asus A9RP
> > 
> > Cheers,
> > Sören
> > 
> > Signed-off-by: Sören Wellhöfer <soeren.wellhoe...@gmx.net>
> 
> I appreciate the effort of sharing such changes, personally - don't know
> if Linus is taking patches for such old kernels, probably not, so the the
> signed-off is probably unnecessary :-). I have one comment though - the patch
> is neither minimal (you added a couple of strictly-speakingnot-necessary
> debug print statements, and there is a whitespace change noted below), nor
> maximal - maximal would be back-porting the current code, i.e. a subset of
> the compat-wireless objective. Have you looked at compat-wireless? I don't
> know if it runs as earlier as 2.6.22, but I think it does.
> 
> > diff -uprN
> > 2.6.22.6-vanilla/drivers/net/wireless/zd1211rw/zd_rf.c
> > 2.6.22.6/drivers/net/wireless/zd1211rw/zd_rf.c
> > ---
> > 2.6.22.6-vanilla/drivers/net/wireless/zd1211rw/zd_rf.c   
> > 2009-04-23 11:36:28.000000000 +0200
> > +++
> > 2.6.22.6/drivers/net/wireless/zd1211rw/zd_rf.c   
> > 2009-08-04 15:55:05.000000000 +0200
> > @@ -25,7 +25,7 @@
> >  
> >  static const char * const rfs[] = {
> >      [0]   
> >     = "unknown RF0",
> > -    [1]   
> >     = "unknown RF1",
> > +    [1]   
> >     = "unknown RF1", 
> >      [UW2451_RF]    =
> > "UW2451_RF",
> >      [UCHIP_RF]    =
> > "UCHIP_RF",
> >      [AL2230_RF]    =
> > "AL2230_RF",
> 
> White space change, probably unintentional or indicative of a bug?
> 
> 
> 
>       

-- 
Sören Wellhöfer
Carl-Zeiss-Gymnasium Jena / Specialised school for Math, Science, and Technology



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Zd1211-devs mailing list - http://zd1211.wiki.sourceforge.net/
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/zd1211-devs

Reply via email to