On 19 March 2011 16:41, Martin Sustrik <[email protected]> wrote:

> As a side note: The patch seems to mix several issues. AFAICS aside of
> HTTP thing, there's some logging functionality, some PGM related changes
> etc.
>
>
The HTTP side is a bit weird, the code follows basic 1.0 paradigm but
requests version 1.1.  Also, it doesn't appear to play well with any other
HTTP client request and such it would quickly fail with any simple fuzzing
test.

The PGM changes seem to be due to cloning an old revision of the git repo.
 The logging additions are overly sloppy though, why are the log macros only
commented out in the third commit and not completely removed?

-- 
Steve-o
_______________________________________________
zeromq-dev mailing list
[email protected]
http://lists.zeromq.org/mailman/listinfo/zeromq-dev

Reply via email to