On Tue, Jan 10, 2012 at 1:46 AM, Martin Lucina <[email protected]> wrote:
> You misunderstood what I wrote; I'm not arguing against using pull > requests, I'm arguing against *mandating* the Github *interface* to pull > requests. The Github stuff is just a wrapper that (AFAIK) creates a > branch for each pull request. It does much more than that. There is a manual process for merging pull requests. It's several steps and error prone. It offers no discussion thread, no workflow. Then there is github's UI, which checks that merging is possible does the merging automatically when you ask it, offers workflow (cancel, close), ties pull requests into issues, and offers a single place for discussion. Take a look at the hundred or so pull requests we've had on the Guide. It's simple, consistent, and idiot proof. -Pieter _______________________________________________ zeromq-dev mailing list [email protected] http://lists.zeromq.org/mailman/listinfo/zeromq-dev
