Just a quick note while I'm reading the code and deeply enough in it:
It seems that _added_during_commit is not needed anymore. At the time
it was introduced,
the add() method didn't also _register its objects, but put them in
Nowadays all added objects end up in _registered_objects, so the
simple for loop in _commit should be enough to also catch those added
The test checkModifyOnGetstate (and all other tests) still passes if
I comment out the relevant code in add().
PS: I'll take the time in a few weeks to review the messages I posted
here and checkin changes for those who have received approval. But I
don't have the bandwidth right now.
Florent Guillaume, Nuxeo (Paris, France) Director of R&D
+33 1 40 33 71 59 http://nuxeo.com [EMAIL PROTECTED]
For more information about ZODB, see the ZODB Wiki:
ZODB-Dev mailing list - ZODB-Dev@zope.org