On Fri, Nov 20, 2009 at 11:49 AM, Tres Seaver <[email protected]> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Tres Seaver wrote:
>> Jim Fulton wrote:
>>> On Fri, Nov 20, 2009 at 5:49 AM, Chris Withers <[email protected]>
>>> wrote:
>>>> Hi Jim,
>>>>
>>>> It would be great if the two recent fixes I committed could make it into a
>>>> 3.9.4 release some time soon...
>>>>
>>>> What can I do to help this happen?
>>>> Assuming I do anything necessary, when could you do this release?
>>>> (or give Christian permission to do it :-) )
>>> I need to review the changes before the release. I'll probably reject the
>>> repozo change without an automated test.
>>
>> -sys.maxint. In what possible universe are we better off not being able
>> to run repozo under Python 2.6?
You can run repozo under Python 2.6 now. You'll get a deprecation warning.
>> That fix is trivial to inspect for
>> correctness, changes no behavior, and is like dozens of other Python 2.6
>> compatiblitity changes made in our codebase.
>>
>> Repozo is *the* documented way of backing up filestorages:
Where is that?
>> with Zope
>> 2.12 and later now running on Python 2.6, we should just tell people
>> "Sorry, you can't do backups"?
No, we should tell them they should use a mostly untested tool to do backups
that doesn't work with blobs. That should inspire confidence.
Does Zope 2.12 use Blobs?
> I just checked in a stupid test to ensure that repozo can be imported.
>
> - --- src/ZODB/scripts/tests.py (revision 105913)
> +++ src/ZODB/scripts/tests.py (working copy)
> @@ -26,6 +26,11 @@
> (re.compile('hash=[0-9a-f]{40}'),
> 'hash=b16422d09fabdb45d4e4325e4b42d7d6f021d3c3')])
>
> +class RepozoTests(unittest.TestCase):
> +
> + def test_importability(self):
> + from ZODB.scripts import repozo
> +
I appreciate your dedication to quality.
That test passes under ZODB 3.9.3 with Python 2.6.
Jim
--
Jim Fulton
_______________________________________________
For more information about ZODB, see the ZODB Wiki:
http://www.zope.org/Wikis/ZODB/
ZODB-Dev mailing list - [email protected]
https://mail.zope.org/mailman/listinfo/zodb-dev
