[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616545#action_12616545
 ] 

Patrick Hunt commented on ZOOKEEPER-78:
---------------------------------------

Hi James -- I understand where you are coming from and we appreciate the 
effort, but regarding use of SVN for patch submission - I'm afraid this is not 
acceptable. Notice on the "attach patch" JIRA page that it has the " Grant 
license to ASF for inclusion in ASF works .... " option. This has to be checked 
for us to consider a patch for inclusion.

Also consider that we have limited resources/time and need to follow the 
designated patch process in order to optimize around the limited set of core 
reviewers/commiters we have relative to the community at large.

(if you think you've got it bad checkout some of the hadoop examples like: 
https://issues.apache.org/jira/browse/HADOOP-3412)

What I'd suggest is that you "overwrite" the existing patch when submitting an 
update. If you upload a file with the same name the old version of the file 
_is_ still available in the JIRA, and the new file will take it's place. (I 
need to update the wiki with this, just haven't gotten around to it - ok just 
added near the end of the "contributing your work section", thanks)

A bit less important but wanted to mention the naming scheme defined on the 
following page (creating a patch section):
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
ZOOKEEPER-#.patch
This helps reviewers/committers keep all the patches straight. :-)

> added a high level protocol/feature - for easy Leader Election or exclusive 
> Write Lock creation
> -----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-78
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: james strachan
>         Attachments: patch_with_including_Benjamin's_fix.patch, 
> using_zookeeper_facade.patch
>
>
> Here's a patch which adds a little WriteLock helper class for performing 
> leader elections or creating exclusive locks in some directory znode. Note 
> its an early cut; am sure we can improve it over time. The aim is to avoid 
> folks having to use the low level ZK stuff but provide a simpler high level 
> abstraction.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to