[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616579#action_12616579
 ] 

james strachan commented on ZOOKEEPER-78:
-----------------------------------------

Wow I confess to be being kinda surprised by that response :) I didn't realise 
you guys were so attached to the exact svn command line used to apply a patch - 
I thought you'd welcome all contributions and that the svn commit history would 
be more useful to you, given the large amount of changes and complexity of the 
code and large number of comments already on this JIRA - rather than focus 
purely on a minor couple of keystrokes required apply the patch :)  

FWIW I've attached about 5 patch files so far, with none of them being 
committed anywhere - then made about 7 patches since then in svn with history 
and I'm sure there'll be another 5 or so changes to go before this patch is 
done. 

Never mind - I'll happily comply with your strict patch acceptance policy. Give 
me a few weeks or so to completely finish the code and documentation and I'll 
submit a single big patch for all the work to this JIRA. If you want you can 
get all the history too with a trivial alternative svn command - but if that 
offends you, please forget I'm using a sandbox svn area to work on this 
(pretend I'm just saving it on my hard drive and please disregard the links 
I've added to some JIRAs to refer to parts of this patch in a simple way) and 
just use the single patch file I'll attach in a few weeks or so.


> added a high level protocol/feature - for easy Leader Election or exclusive 
> Write Lock creation
> -----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-78
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>    Affects Versions: 3.0.0
>            Reporter: james strachan
>         Attachments: patch_with_including_Benjamin's_fix.patch, 
> using_zookeeper_facade.patch
>
>
> Here's a patch which adds a little WriteLock helper class for performing 
> leader elections or creating exclusive locks in some directory znode. Note 
> its an early cut; am sure we can improve it over time. The aim is to avoid 
> folks having to use the low level ZK stuff but provide a simpler high level 
> abstraction.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to