[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694791#action_12694791
 ] 

Hadoop QA commented on ZOOKEEPER-343:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12402861/ZOOKEEPER-343.patch
  against trunk revision 761077.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 4 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/6/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/6/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/6/console

This message is automatically generated.

> add tests that specifically verify the zkmain and qpmain classes
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-343
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-343.patch
>
>
> We are missing tests for these two main() routines.
> Add tests that verify standalone and quorum (2 servers is probably enough) by 
> starting and connecting a client.
> Use on-disk configuration files to configure these.
> (ie verify starting with actual config files)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to