[
https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696251#action_12696251
]
Mahadev konar commented on ZOOKEEPER-343:
-----------------------------------------
i am really glad that you removed this
{code}
runStandalone(new ZooKeeperServer.Factory()
{code}
That zookeeperserver factory used to annoy me a lot.
I have one question though --
- you have removed the QuorumpeerConfig inheting from ServerConfig...
I actually liked that and would like to keep it. Imagine we just passed around
configs in our server code inside al lthe processors. I would like to have one
common interface to pass around all the config stuff that can be used by all
the code on the server side.
> add tests that specifically verify the zkmain and qpmain classes
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-343
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343
> Project: Zookeeper
> Issue Type: Improvement
> Components: tests
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-343.patch, ZOOKEEPER-343.patch
>
>
> We are missing tests for these two main() routines.
> Add tests that verify standalone and quorum (2 servers is probably enough) by
> starting and connecting a client.
> Use on-disk configuration files to configure these.
> (ie verify starting with actual config files)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
