[
https://issues.apache.org/jira/browse/ZOOKEEPER-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705122#action_12705122
]
Advertising
Patrick Hunt commented on ZOOKEEPER-386:
----------------------------------------
Henry, this sounds great! Thanks for the submission. However i'm afraid that
neither Mahadev nor I can apply this patch. We keep getting:
patch: **** malformed patch at line 1196: Index: build.xml
I tried editing the patch file a bit, but for some reason it won't patch even
though it looks fine.
Could you use SVN to re-create the patch? ie "svn diff" and resubmit?
--------
Also, a few items I noticed:
1) please name the patch after the JIRA - ZOOKEEPER-386.patch in this case:
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
2) zkCli.sh in bin directory should be updated to include the new jar on the
classpath
3) is there some way (introspection?) we can support a shell that uses jline if
the jar
is available, however drops back to non-jline if the jar is not available?
----
Thanks for the submission, look forward to getting this one in.
> improve java cli shell
> ----------------------
>
> Key: ZOOKEEPER-386
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-386
> Project: Zookeeper
> Issue Type: Improvement
> Components: java client
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: patch.txt
>
>
> copied from the following comments by Vegard
> https://issues.apache.org/jira/browse/ZOOKEEPER-364?focusedCommentId=12696002&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696002
> ------------------------------------------------------------
> Possible improvements:
> Default host list to localhost:2181 when not given.
> Don't print a ton of debug, it looks like both cli_mt and zkCli.sh does this.
> Make a simple ls that lists subnodes one line at a time and a simple cat that
> lists only the node content, simple put etc.
> Shell with gnu readline capabilities and tab completion on node names would
> be a big improvement of usability during testing and debugging.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
