Henry Robinson updated ZOOKEEPER-386:

    Attachment: ZOOKEEPER-386.patch

Weird, I had the same error with the patch. Not sure what went wrong, sorry 
about that. Attached is a version that I've tested on a clean svn pull.

Regarding your other points:

- zkCli.sh - doesn't zkEnv.sh make sure that all jars in $ZOOLIBDIR (which is 
bin/../lib on my machine) get added to the classpath? So putting the jline jar 
there would be sufficient. What's the best way to make that happen for a 

- It would, I think, be possible to load jline only at runtime. Unfortunately 
there doesn't seem to be a way to do it that doesn't really overcomplicate 
things. I tried catching the NoClassDefFoundError exception when instantiating 
the console object; that works great but unfortunately the jvm tries to load 
the ZNodeCompletor object at start-up time which means I can't install the 
exception handler. If there's a lightweight way to do this that keeps the code 
to one source file (I believe it's going too far to substantially restructure 
the shell client just for this feature, but let me know if you think 
differently), I'll be really happy to do it.

> improve java cli shell
> ----------------------
>                 Key: ZOOKEEPER-386
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-386
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>             Fix For: 3.2.0
>         Attachments: patch.txt, ZOOKEEPER-386.patch
> copied from the following comments by Vegard
> https://issues.apache.org/jira/browse/ZOOKEEPER-364?focusedCommentId=12696002&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12696002
> ------------------------------------------------------------
> Possible improvements:
> Default host list to localhost:2181 when not given.
> Don't print a ton of debug, it looks like both cli_mt and zkCli.sh does this. 
> Make a simple ls that lists subnodes one line at a time and a simple cat that 
> lists only the node content, simple put etc.
> Shell with gnu readline capabilities and tab completion on node names would 
> be a big improvement of usability during testing and debugging. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to