Henry Robinson updated ZOOKEEPER-336:

    Attachment: ZOOKEEPER-336.patch

Here is the new patch. Improvements are: tidied up formatting / added some 
comments to a public constructor / added a new test which validates the 
connection limiting.

There is, of course, the question of whether this functionality belongs in 
ZooKeeper and not an iptables rule or similar. I think it's helpful to have 
this in the ZK server to provide an easy fix for misbehaving clients.

> single bad client can cause server to stop accepting connections
> ----------------------------------------------------------------
>                 Key: ZOOKEEPER-336
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-336
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client, java client, server
>            Reporter: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.2.0
>         Attachments: ZOOKEEPER-336.patch, ZOOKEEPER-336.patch
> One user saw a case where a single mis-programmed client was overloading the 
> server with connections - the client was creating a huge number of sessions 
> to the server. This caused all of the fds on the  server to become used.
> Seems like we should have some way of limiting (configurable override) the 
> maximum number of sessions from a single client (say 10 by default?) Also we 
> should output warnings when this limit is exceeded (or attempt to exceed).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to