[ https://issues.apache.org/jira/browse/ZOOKEEPER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714734#action_12714734 ]
Hadoop QA commented on ZOOKEEPER-336: ------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12409460/ZOOKEEPER-336.patch against trunk revision 780122. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/97/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/97/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/97/console This message is automatically generated. > single bad client can cause server to stop accepting connections > ---------------------------------------------------------------- > > Key: ZOOKEEPER-336 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-336 > Project: Zookeeper > Issue Type: Improvement > Components: c client, java client, server > Reporter: Patrick Hunt > Assignee: Henry Robinson > Priority: Critical > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-336.patch, ZOOKEEPER-336.patch, > ZOOKEEPER-336.patch, ZOOKEEPER-336.patch > > > One user saw a case where a single mis-programmed client was overloading the > server with connections - the client was creating a huge number of sessions > to the server. This caused all of the fds on the server to become used. > Seems like we should have some way of limiting (configurable override) the > maximum number of sessions from a single client (say 10 by default?) Also we > should output warnings when this limit is exceeded (or attempt to exceed). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.