[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719006#action_12719006
 ] 

Patrick Hunt commented on ZOOKEEPER-443:
----------------------------------------

we could remove the extra check in zootrace, it's essentially a noop, I left it 
just because I wanted
to change as little as possible. ;-) Feel free to update the patch.

wrt to your other comment, I wrapped everything with a check, mainly so that 
the code is
consistent in idiom throughout (and when ppl copy they continue to use, 
etc...), but also
since we don't know what logRequest might be changed to at some point. Really 
we should
have this wrapper for all debug/trace calls.


> trace logging in watch notification not wrapped with istraceneabled - 
> inefficient
> ---------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-443
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-443
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-443.patch
>
>
> In org.apache.zookeeper.server.NIOServerCnxn.process(WatchedEvent) there's a 
> trace message
> that's not wrapped with isTraceEnabled, this is very inefficient and should 
> be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to