[
https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-420:
-------------------------------------
Attachment: ZOOKEEPER-420.patch
Here's a patch which fixes some of the issues with testing.
1. compiling the extension now looks for C libraries in src/c/.libs before
/usr/local/lib, so should be able to link without having installed the C
libraries (but they must still have been built, and I still don't know if
there's an ant target I should depend on for that)
2. Running the tests now adds build/contrib/zkpython/[libdir] to PYTHONPATH, so
zookeeper.so will get picked up there if it exists.
3. Similarly, src/c/.libs gets added to both LD_LIBRARY_PATH and
DYLD_LIBRARY_PATH (mac os equivalent) when the tests are run, so 'import
zookeeper' should succeed.
I'm looking into how to bundle a C library with a Python egg so that zkpython
is distributable standalone. This is a separate issue, though.
> build/test should not require install in zkpython
> -------------------------------------------------
>
> Key: ZOOKEEPER-420
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch
>
>
> Currently you cannot just build and test the zkpython contrib, you need to
> actually install the zookeeper client c library as well
> as the zkpython lib itself.
> There really needs to be 2 steps:
> 1) build/test zkpython "encapsulated" within the src repository, there should
> be no requirement to actually install anything
> (this is esp the case for automated processes and for review by PMC during
> release time for example)
> 2) build an egg that can be distributed/installed by end user
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
