[
https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758806#action_12758806
]
Patrick Hunt commented on ZOOKEEPER-420:
----------------------------------------
Henry, this sounds good, however you need one more path for 1) & 3)
If the user types "ant test" from the toplevel build, all the java/c code will
be compiled/tested. If the user then
cd's into src/contrib/zkpython and types "ant test" it will fail. The reason is
that the c code is compiled
into the build directory (build/test/test-cppunit/.libs) rather than
src/c/.libs when the "ant test" target is run.
Re ensuring the lib is built - you might take a look at what's done for
ensuring that the java classes are build for
contribs like the "rest" contrib. You could do similar for zkpython but for the
c lib (might be more trouble than it's worth though).
Perhaps I missed it, but you should mention the PYTHONPATH in the readme
(docs). I was trying LD_LIBRARY_PATH and
was suprised that python interp couldn't find the zookeeper.so, eventually I
just gave up and copied the file. If I would
have know about PP it would have helped.
> build/test should not require install in zkpython
> -------------------------------------------------
>
> Key: ZOOKEEPER-420
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch
>
>
> Currently you cannot just build and test the zkpython contrib, you need to
> actually install the zookeeper client c library as well
> as the zkpython lib itself.
> There really needs to be 2 steps:
> 1) build/test zkpython "encapsulated" within the src repository, there should
> be no requirement to actually install anything
> (this is esp the case for automated processes and for review by PMC during
> release time for example)
> 2) build an egg that can be distributed/installed by end user
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
