[ https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761349#action_12761349 ]
Hadoop QA commented on ZOOKEEPER-420: ------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420574/ZOOKEEPER-420.patch against trunk revision 818584. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/0/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/0/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/0/console This message is automatically generated. > build/test should not require install in zkpython > ------------------------------------------------- > > Key: ZOOKEEPER-420 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings > Reporter: Patrick Hunt > Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: build.jpg, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, > ZOOKEEPER-420.patch, ZOOKEEPER-420.patch, ZOOKEEPER-420.patch > > > Currently you cannot just build and test the zkpython contrib, you need to > actually install the zookeeper client c library as well > as the zkpython lib itself. > There really needs to be 2 steps: > 1) build/test zkpython "encapsulated" within the src repository, there should > be no requirement to actually install anything > (this is esp the case for automated processes and for review by PMC during > release time for example) > 2) build an egg that can be distributed/installed by end user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.