Henry Robinson commented on ZOOKEEPER-549:

Mahadev / Flavio -  

Thanks for the comments!

I agree about renaming from Peer; Learner isn't a bad name. If no-one has a 
better suggestion, I'll do that :)

Good point on the downcasts, I'll remove the unnecessary ones. Also good catch 
on the imports; I rely on Eclipse to catch them and it sometimes doesn't. 

Definitely agree on the testing; but since this is a rearrangement of code it's 
not clear how to write many more functional tests since we already have some 
coverage. Is anyone running a stress test workload? I've just got my hands on 
some resources to do something similar, but setting it up would take a bit of 

I think there are a host of refactorings that could still stand to be done on 
this code and elsewhere. I agree on the package split, that probably belongs in 
this JIRA.

> Refactor Followers and related classes into a Peer->Follower hierarchy in 
> preparation for Observers
> ---------------------------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-549
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-549
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: quorum, server
>    Affects Versions: 3.2.1
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-549.patch, ZOOKEEPER-549.patch
> For the Observers patch (ZOOKEEPER-368), a lot of functionality is shared 
> between Followers and Observers. To avoid copying code, it makes sense to 
> push the common code into a parent Peer class and specialise it for Followers 
> and Observers. At the same time, some of the lengthier methods in Follower 
> can be broken up to make the code more readable. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to