Flavio Paiva Junqueira commented on ZOOKEEPER-549:

Nice job, Henry! I have just a quick question about FOLLOWERINFO. I've noticed 
that in your patch one of the Learner methods is registerWithLeader(), and this 
method takes a packet type. I'm assuming that you have not replaced 
FOLLOWERINFO with LEARNERINFO, and that registerWithLeader takes a packet type 
as parameter because observers will send something like OBSERVERINFO?

Assuming that what I said is correct, what if learners send LEARNERINFO, and 
the leader verifies the status of the server against its configuration?

I apologize if I'm mixing jiras here. I'm just trying to understand why 
FOLLOWERINFO hasn'changed.

> Refactor Followers and related classes into a Peer->Follower hierarchy in 
> preparation for Observers
> ---------------------------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-549
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-549
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: quorum, server
>    Affects Versions: 3.2.1
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-549.patch, ZOOKEEPER-549.patch, 
> ZOOKEEPER-549.patch, ZOOKEEPER-549.patch
> For the Observers patch (ZOOKEEPER-368), a lot of functionality is shared 
> between Followers and Observers. To avoid copying code, it makes sense to 
> push the common code into a parent Peer class and specialise it for Followers 
> and Observers. At the same time, some of the lengthier methods in Follower 
> can be broken up to make the code more readable. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to