Patrick Hunt updated ZOOKEEPER-555:

    Attachment: ZOOKEEPER-555.patch

This is Arni's patch with the following changes:

1) resolved findbugs issues (on my system at least)
2) fixed the "ls2" command in the Java CLI
3) minor changes to the c/java api docs
4) changed ZooDefs.OpCode.getChildren1 back to getChildren as this is a public
interface (granted it shouldn't be used by outside code but it is public, safer 
to keep
it the same name)

5) I also removed the StringsAndStat jute type. Not that it was bad,
but it wasn't used in the c code and it's not consistent with the current Java 
api (getData for
example). As part of this I removed getChildren2 and overloaded getChildren 
with Stat param.
Better? Worse? Comments?

ps.  I verified that filling in the stat and the child list is done under a 
node lock (would be good for
any other reviewer to also check my check).

> Add stat information to GetChildrenResponse
> -------------------------------------------
>                 Key: ZOOKEEPER-555
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-555
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client, contrib-bindings, java client, server
>    Affects Versions: 3.3.0
>            Reporter: Árni Már Jónsson
>            Assignee: Árni Már Jónsson
>            Priority: Minor
>             Fix For: 3.3.0
>         Attachments: getchildren_stat.patch, ZOOKEEPER-555.patch, 
> ZOOKEEPER-555.patch
> GetChildren() is the only non-create/delete API which does not include the 
> node stat information. I propose that the definition of GetChildren() should 
> be:
>     class GetChildrenResponse {
>         vector<ustring> children;
>         org.apache.zookeeper.data.Stat stat;
>     }
> There is a trivial fix to the server (FinalRequestProcessor.java): rsp = new 
> GetChildrenResponse(children, stat);
> And something similar to the  client library.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to